logging export drops for otel now#912
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves observability of the OTEL non-blocking export path by emitting a log message when the export channel is full and a metric sample is dropped, helping users identify which metrics are affected (per Issue #908).
Changes:
- Add a warning log on OTEL export drop events, including the metric name being dropped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@dconnolly-sfdc, does this work for your use case? I'm nervous about logging at warn level in the hot loop of all exports. |
Comment on lines
+236
to
+238
| f.metrics.ExportDrops.Inc(1) | ||
| if !f.warnFull[m.Name] { | ||
| f.Warnf("OTEL channel full, dropping sample for metric=%s", m.Name) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@i3149 yes Ian, this will work for us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #908
Better logging for otel.